seafloor-geodesy / gnatss

Community Seafloor Global Navigation Satellite Systems - Acoustic (GNSS-A) Transponder Surveying Software
https://gnatss.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
10 stars 14 forks source link

feat: Add Residual Plotting Functionality #174

Closed lsetiawan closed 11 months ago

lsetiawan commented 11 months ago

Overview

This PR initialized qc module and residual plotting functionality such as plotting the ENU components and residuals together with outliers/deletions flagging.

Reference

Issue #149 Issue #148

Demo Plots

Residuals

res

ENU Components

enu_comps

codecov[bot] commented 11 months ago

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (5b2c526) 42.22% compared to head (a67579f) 38.39%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #174 +/- ## ========================================== - Coverage 42.22% 38.39% -3.83% ========================================== Files 15 16 +1 Lines 746 823 +77 ========================================== + Hits 315 316 +1 - Misses 431 507 +76 ``` | [Files](https://app.codecov.io/gh/uw-ssec/offshore-geodesy/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ssec) | Coverage Δ | | |---|---|---| | [src/gnatss/cli.py](https://app.codecov.io/gh/uw-ssec/offshore-geodesy/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ssec#diff-c3JjL2duYXRzcy9jbGkucHk=) | `29.78% <0.00%> (-6.12%)` | :arrow_down: | | [src/gnatss/ops/qc.py](https://app.codecov.io/gh/uw-ssec/offshore-geodesy/pull/174?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ssec#diff-c3JjL2duYXRzcy9vcHMvcWMucHk=) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/uw-ssec/offshore-geodesy/pull/174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uw-ssec)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lsetiawan commented 11 months ago

@johnbdesanto Please let me know if the demo plots above looks okay to you. The time axis seems like there might be too much ticks... currently it defaults to 25 ticks.. maybe I need to reduce this.

johnbdesanto commented 11 months ago

The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels.

I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine.

lsetiawan commented 11 months ago

The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels.

That's what I thought. I actually made the underlying function super easy to adjust the ticks, so yes we can reduce it. I set to 15 and this is what I get:

Screenshot 2023-10-16 at 4 27 55 PM

I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine.

Thanks for checking on that. I haven't really thought about the colors. I will change that to make sure it's the most colorblind friendly!

Really appreciate your input @johnbdesanto 😄

lsetiawan commented 11 months ago

Updated demo after n_ticks = 15 and now using a more colorblind friendly colors

res

enu_comps

lsetiawan commented 11 months ago

Couple of inline comments and looks like some missing tests.

Thanks! I'm skipping tests for now. Trying to get this out for user testing atm