Closed lsetiawan closed 11 months ago
Attention: 72 lines
in your changes are missing coverage. Please review.
Comparison is base (
5b2c526
) 42.22% compared to head (a67579f
) 38.39%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@johnbdesanto Please let me know if the demo plots above looks okay to you. The time axis seems like there might be too much ticks... currently it defaults to 25
ticks.. maybe I need to reduce this.
The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels.
I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine.
The ticks on the x-axis are a little dense. If there's a way to reduce the ticks to the 15-20 range, I suspect that that might be easier to parse the axis labels.
That's what I thought. I actually made the underlying function super easy to adjust the ticks, so yes we can reduce it. I set to 15
and this is what I get:
I was concerned that the plot may be colorblind-unfriendly, but after checking with coblis it seemed fine.
Thanks for checking on that. I haven't really thought about the colors. I will change that to make sure it's the most colorblind friendly!
Really appreciate your input @johnbdesanto 😄
n_ticks = 15
and now using a more colorblind friendly colorsCouple of inline comments and looks like some missing tests.
Thanks! I'm skipping tests for now. Trying to get this out for user testing atm
Overview
This PR initialized qc module and residual plotting functionality such as plotting the ENU components and residuals together with outliers/deletions flagging.
Reference
Issue #149 Issue #148
Demo Plots
Residuals
ENU Components