search

seafloor-geodesy / gnatss

Community Seafloor Global Navigation Satellite Systems - Acoustic (GNSS-A) Transponder Surveying Software
https://gnatss.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
9 stars 13 forks source link

feat: Add option for gnatss for user flag file to remove bad data #195

Closed madhavmk closed 7 months ago

madhavmk commented 7 months ago

Fixes #141

codecov[bot] commented 7 months ago

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (a5537f8) 50.60% compared to head (ef7df34) 49.83%.

Files Patch % Lines
src/gnatss/loaders.py 12.50% 14 Missing :warning:
src/gnatss/main.py 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #195 +/- ## ========================================== - Coverage 50.60% 49.83% -0.77% ========================================== Files 16 16 Lines 905 929 +24 ========================================== + Hits 458 463 +5 - Misses 447 466 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

madhavmk commented 7 months ago

I have created Issue #196 to add unittests for this feature. I will look into this on a future date.

madhavmk commented 7 months ago

Hello @lsetiawan , I made the changes as discussed, and updated the PR ! Please let me know if anything else needs to be modified.

madhavmk commented 7 months ago

Hello @lsetiawan, After your suggestion, I have made row-headers mandatory in the quality-controls files. Please note that although row-headers have to be present in the csv-files, the program will still use the predefined starttime, endtime, notes pre-defined columns when defining the qc_df dataframe.