search

seagle0128 / doom-modeline

A fancy and fast mode-line inspired by minimalism design.
https://seagle0128.github.io/doom-modeline/
GNU General Public License v3.0
1.29k stars 159 forks source link

Add support for updating forge notifications when the counter changes #680

Closed benthamite closed 11 months ago

benthamite commented 11 months ago

I’m not sure if there is interest in this functionality, but I thought it could be useful for those who use forge to check GitHub notifications. It modifies doom-modeline--github-fetch-notifications and adds a user option, doom-modeline-github-update-forge, such that when its value is non-nil, an update to doom-modeline--github-notification-number will trigger the fetching of notifications in forge. This ensures that the notification counter correctly reflects the number of forge unread notifications, which may otherwise diverge.

I’m relatively new to programming and Elisp specifically, so feel free to reject or suggest revisions.

seagle0128 commented 11 months ago

I think it's better add a hook, and let the users make the decision.

benthamite commented 11 months ago

Makes sense. Let me know if this works.