Closed garyo closed 8 months ago
Thank you for the kind reminder!
This fix results in error on Emacs 29.1:
error in process filter: doom-modeline--eglot-pending-count: Symbol’s function definition is void: jsonrpc--continuations error in process filter: Symbol’s function definition is void: jsonrpc--continuations
@uqix I reverted 9773ef7. Sorry for the inconvenience!
@garyo In 9773ef7, the compatibility has been considered.
Hi, should I unpin the package to use the fixed version?
@pcompassion pls use the latest version.
@seagle0128 thanks for the response, but i tried doing
(unpin! doom-modeline) in my packages.el and even changing the
(unless (modulep! +light) (package! doom-modeline :pin "93f240f7a0bf35511cfc0a8dd75786744b4bcf77")) to
(unless (modulep! +light) (package! doom-modeline))
and doing doom-sync, doens't give me the latest version..
@pcompassion I think you should file an issue for doom emacs.
@pcompassion maybe you need doom sync -u
[1]?
[1] https://github.com/doomemacs/doomemacs/blob/master/docs/getting_started.org#the-bindoom-utility
You’ll need doom sync -u if you override the recipe of package installed by another module.
@seagle0128 @pcompassion thanks for the responses, i'll handle it
Thank you for the bug report
doom-modeline
related packages.emacs -Q
.Bug description
In emacs commit dceffddbfe7,
jsonrpc--request-continuations
is replaced withjsonrpc--continuations
inlisp/jsonrpc.el
. As of doom-modeline a312ea8,doom-modeline-segments.el
uses the old accessor function.This trivial patch fixes it for me:
but I expect the actual fix will need to cover both cases for compatibility.
Steps to reproduce
Try to use eglot with doom-modeline, using latest master emacs.
Expected behavior
Should work without error.
OS
Windows
Emacs Version
30
Emacs Configurations
No response
Error callstack
No response
Anything else
No response