seagle0128 / doom-modeline

A fancy and fast mode-line inspired by minimalism design.
https://seagle0128.github.io/doom-modeline/
GNU General Public License v3.0
1.29k stars 159 forks source link

[Bug] Typo in commit 3f1d33a #709

Closed dr-scsi closed 7 months ago

dr-scsi commented 7 months ago

Thank you for the bug report

Bug description

There is a typo in line 886 after commit 3f1d33a: https://github.com/seagle0128/doom-modeline/blob/3f1d33a043d48080f3e0b370de5759beef8a8c09/doom-modeline-segments.el#L886

Steps to reproduce

Check the commit mentioned above.

Expected behavior

The following change should cure the issue:

diff --git a/doom-modeline-segments.el b/doom-modeline-segments.el
index 1195027..ede2715 100644
--- a/doom-modeline-segments.el
+++ b/doom-modeline-segments.el
@@ -883,7 +883,7 @@ mouse-2: Show help for minor mode")
                                                 (doom-modeline-check-text (number-to-string .info)
                                                                           'doom-modeline-info)))
                                   ('icons (format "%s %s %s %s %s"
-                                                  doom-modeline-check-error- icon
+                                                  doom-modeline-check-error-icon
                                                   (doom-modeline-check-text (number-to-string .error)
                                                                             'doom-modeline-urgent)
                                                   doom-modeline-check-warning-icon

OS

MacOS

Emacs Version

30 (gccemacs)

Emacs Configurations

No response

Error callstack

N/A

Anything else

The compiler also complains about:

In doom-modeline-update-flymake-text:
doom-modeline-segments.el:1089:36: Warning: ‘format’ called with 6 args to fill 5 format field(s)

Maybe you can check the line above and 885 about the number of %s and the following args -- 6 %s looks like the correct number to me. This is also the reason why I'm not providing a PR. TIA.