seagle0128 / doom-modeline

A fancy and fast mode-line inspired by minimalism design.
https://seagle0128.github.io/doom-modeline/
GNU General Public License v3.0
1.27k stars 157 forks source link

Add optional support for icons in check segment #711

Closed DevelopmentCool2449 closed 5 months ago

DevelopmentCool2449 commented 5 months ago

This a improved and fixed version of this PR https://github.com/seagle0128/doom-modeline/pull/706, this should fix some bugs from original patch like icons in inactive windows, &c.

seagle0128 commented 5 months ago

I tested with the latest commit, and found the icons in the inactive windows are still not right.

image

And, the doom-modeline-icon option is not respected.

image

DevelopmentCool2449 commented 5 months ago

I tested with the latest commit, and found the icons in the inactive windows are still not right.

image

It should now be fixed.

And, the doom-modeline-icon option is not respected.

image

I don't know how to reproduce that issue, but i think it should be fixed too, it now uses doom-modeline-display-icon for icons and doom-modeline-display-text for error counters, tell me if the issue still

seagle0128 commented 5 months ago

I tested with the latest commit, and found the icons in the inactive windows are still not right. image

It should now be fixed.

And, the doom-modeline-icon option is not respected. image

I don't know how to reproduce that issue, but i think it should be fixed too, it now uses doom-modeline-display-icon for icons and doom-modeline-display-text for error counters, tell me if the issue still

This issue has been fixed in the latest commit.

seagle0128 commented 5 months ago

I reimplement the check segment. The behavior is exactly same as VSCode. Please check and test feat/check-icons branch. PR: https://github.com/seagle0128/doom-modeline/pull/712

doom-modeline-check-simple-format => nil image

doom-modeline-check-simple-format => t image

DevelopmentCool2449 commented 5 months ago

I reimplement the check segment. The behavior is exactly same as VSCode. Please check and test feat/check-icons branch. PR: #712

doom-modeline-check-simple-format => nil image

doom-modeline-check-simple-format => t image

Works fine, i like more that version than mine, maybe it should have "⌛" icon like original, but i don't dislike it.

seagle0128 commented 5 months ago

Okay. I will consider the suggestion and improve it.

seagle0128 commented 5 months ago

Closed by #712.