search

seagle0128 / icons-in-terminal.el

A utility package to propertize Icon Fonts in both GUI and TUI with Emacs.
GNU General Public License v3.0
35 stars 6 forks source link

Doom Modeline Support #5

Open aquilacf opened 3 years ago

aquilacf commented 3 years ago

Hi there, Before anything thanks for the great work with icons-in-terminal and doom modeline, both awesome packages. I am struggling to setup doom modeline with icons-in-terminal.

Here's a screenshot: image

Config:

(use-package all-the-icons)
(with-eval-after-load 'all-the-icons
  (defalias #'all-the-icons-insert #'icons-in-terminal-insert)
  (defalias #'all-the-icons-insert-faicon #'icons-in-terminal-insert-faicon)
  (defalias #'all-the-icons-insert-fileicon #'icons-in-terminal-insert-fileicon)
  (defalias #'all-the-icons-insert-material #'icons-in-terminal-insert-material)
  (defalias #'all-the-icons-insert-octicon #'icons-in-terminal-insert-octicon)
  (defalias #'all-the-icons-insert-wicon #'icons-in-terminal-insert-wicon)

  (defalias #'all-the-icons-icon-for-dir #'icons-in-terminal-icon-for-dir)
  (defalias #'all-the-icons-icon-for-file #'icons-in-terminal-icon-for-file)
  (defalias #'all-the-icons-icon-for-mode #'icons-in-terminal-icon-for-mode)
  (defalias #'all-the-icons-icon-for-url #'icons-in-terminal-icon-for-url)

  (defalias #'all-the-icons-icon-family #'icons-in-terminal-icon-family)
  (defalias #'all-the-icons-icon-family-for-buffer #'icons-in-terminal-icon-family-for-buffer)
  (defalias #'all-the-icons-icon-family-for-file #'icons-in-terminal-icon-family-for-file)
  (defalias #'all-the-icons-icon-family-for-mode #'icons-in-terminal-icon-family-for-mode)
  (defalias #'all-the-icons-icon-for-buffer #'icons-in-terminal-icon-for-buffer)

  (defalias #'all-the-icons-faicon #'icons-in-terminal-faicon)
  (defalias #'all-the-icons-octicon #'icons-in-terminal-octicon)
  (defalias #'all-the-icons-fileicon #'icons-in-terminal-fileicon)
  (defalias #'all-the-icons-material #'icons-in-terminal-material)
  (defalias #'all-the-icons-wicon #'icons-in-terminal-wicon)

  (defalias 'all-the-icons-default-adjust 'icons-in-terminal-default-adjust)
  (defalias 'all-the-icons-color-icons 'icons-in-terminal-color-icons)
  (defalias 'all-the-icons-scale-factor 'icons-in-terminal-scale-factor)
  (defalias 'all-the-icons-icon-alist 'icons-in-terminal-icon-alist)
  (defalias 'all-the-icons-dir-icon-alist 'icons-in-terminal-dir-icon-alist)
  (defalias 'all-the-icons-weather-icon-alist 'icons-in-terminal-weather-icon-alist)
  )
(require 'icons-in-terminal)
(use-package doom-modeline
  :ensure t
  :init (doom-modeline-mode 1))

(I have found this alias in some other issue)

Am I missing anything obvious?

seagle0128 commented 3 years ago

I think some codes should be updated since there were some changes of all-the-icons recently.

spudlyo commented 2 years ago

I think the problem with doom-modeline is that it checks display-graphic-p before does anything with fonts. I have this same problem with most packages that use all-the-icons to add icons, and my hacky workaround is the same, I replace instances of (display-graphic-p) with t and recompile the code.

seagle0128 commented 2 years ago

@spudlyo You are right. Another big problem is icons-in-terminal hasn't been maintained for five years, and it doesn't work on Windows yet.