SSR should include styles from assets

seagull-js / seagull

the core of the seagull framework

https://seagull-js.github.io/seagull/

GNU Lesser General Public License v3.0

10 stars 5 forks source link

SSR should include styles from assets #21

Closed Harper04 closed 5 years ago

Anonyfox commented 6 years ago

bonus points: for AMP seagull needs to render all styles (external sheets or inline, whatever) into a single <style /> block in the head of the page. There shall only be this style block and nothing else... since there is no JS allowed on AMP pages, interactive stuff (doing anomations, ...) doesn't matter after initial render.

Usual SSR pages can work as we wish.

Harper04 commented 6 years ago

without bonus point for now https://github.com/seagull-js/seagull-cli/commit/fc34fdb609d8f9cfd81e544245af1f4a24bba8f8

https://github.com/nfl/react-helmet could be an easy and nice way to integrate everything but we need to change layout.tsx

Harper04 commented 5 years ago

does not apply anymore