search

seagull-js / seagull

the core of the seagull framework
https://seagull-js.github.io/seagull/
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Deployment idempotency #99

Closed DfHlyu4aida closed 5 years ago

DfHlyu4aida commented 5 years ago

When a deployment fails the rollback does not clean up everything. Also, if one tries to delete the CloudFormation stack it is still not completely removed.

The issue is that AWS CloudFormation keeps the created log groups. I am quite sure that's intentional, but it's unfortunate, as it does not allow the stack to be rolled out again, because it fails creating these log groups again as they already exist.

Current workaround is to delete these manually, but in that case you also have to know how the name schema is. For the records, it is for remaining log groups:

DfHlyu4aida commented 5 years ago

@Aduril can you reference this issue in the ticket where you're going to fix the cloudwatch issue?

DfHlyu4aida commented 5 years ago

Fixed with version 5.0.0