seahorce-scidac / REMORA

A GPU-enabled version of ROMS
https://remora-ocean.readthedocs.io
Other
11 stars 12 forks source link

Is it possible to translate boundary condition from ROMS to REMORA? #212

Open geogalary opened 4 months ago

geogalary commented 4 months ago

Dear developers,

Good afternoon. I ran into a problem when i'm tring to use REMORA to run my model. But i can't found the same boundary condition option i used in ROMS, like the Cha, Cla, and Nud as below: ! Cha Chapman_implicit (free-surface) ! Che Chapman_explicit (free-surface) ! Cla Clamped ! Clo Closed ! Fla Flather (2D momentum)
! Gra Gradient ! Nes Nested (refinement) ! Nud Nudging ! Per Periodic ! Rad Radiation ! Red Reduced Physics (2D momentum) ! Shc Shchepetkin (2D momentum)

I'm wondering whether this can be developed by ourselves? To achive this, we should translate those fotran codes for boundary condition like ./ROMS/Tangent/tl_zetabc.F in ROMS to c++ in REMORA?

Thank you!

hklion commented 4 months ago

We currently have implemented the equivalents of periodic, clamped, and closed boundary conditions. I just updated the documentation for boundary conditions. Please reply here if anything is unclear. Other boundary conditions are currently planned. Out of curiosity, are there any conditions you're particularly interested in?

If you implement another boundary condition that you think would be helpful to the broader user base, we'd absolutely welcome a pull request. The logic for boundary conditions is handled in the files Source/BoundaryConditions/BoundaryConditions*.