Closed igcontreras closed 4 years ago
I wouldn't merge with master yet.
Sorry, I did not imply that I am trying to merge. I'm just pointing out that there is a conflict and that resolving this conflict early is usually easier than waiting until the PR is ready to be merged.
Sorry I didn't see these messages, is the conflict still there? I fixed one
unless you forced pushed, it would not be resolved. It still says This branch cannot be rebased right above where I type this message
To me it says "This branch has no conflicts with the base branch". I think that I am checking against master
this what I see in the web browser in the PR. It would be strange if you see something different since the page is not generated personally for me :)
Something weird is happening because I see this:
cute :) I'll check manually when I have time and will ignore this message for now
seems like this branch is in conflict with master. Maybe @caballa changed something while the PR is still outstanding. None the less, you should rebase the PR against master before we can merge it.