search

seal-io / walrus

Walrus is an open-source application management platform based on IaC tools including OpenTofu, Terraform and others. It helps platform engineers build golden paths for developers and empowers developers with self-service capabilities.
https://seal.io
Apache License 2.0
426 stars 41 forks source link

Resource configuration missing after editing workflow steps #1891

Closed Finenyaco closed 7 months ago

Finenyaco commented 7 months ago

Describe the bug

Resource configuration missing after editing workflow steps

Steps to reproduce

  1. New a workflow and add a Deploy Resource step.
  2. Edit the step.

Result

  1. Missing resource configuration after editing the step.

https://github.com/seal-io/walrus/assets/26084756/63d5ff84-298f-456e-aebb-85fbcd09fcb1

Expected behavior

Environment

Additional context Add any other context about the problem here.

aiwantaozi commented 7 months ago

Could not reproduce with main abdb301

Finenyaco commented 7 months ago

Environment

Test Result:

Could not reproduce this issue with the latest main version.

But there has been another issue. After adding a 'Deploy Resource' step and editing again, the default values for disabled parameters will disappear.

https://github.com/seal-io/walrus/assets/26084756/bd0c5d4d-627f-4650-9cac-5a6da8a064d1

Finenyaco commented 7 months ago

Environment

Test Result: Some values are still missing after editing.

https://github.com/seal-io/walrus/assets/26084756/32ada8fc-0919-4187-8042-f9f16c4e8421

Finenyaco commented 7 months ago

Environment

Test Result: pass