search

sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

Issue#229 creating the same user #247

Closed arkadiusz-wieczorek closed 8 years ago

arkadiusz-wieczorek commented 8 years ago

It works

23:55:16.877 - info: Sealious@0.6.17 is up-to-date.
23:55:39.739 - info: User ala has been created
23:55:39.754 - info:     POST /api/v1/users
            from: 127.0.0.1, mime: multipart/form-data
            result: success!
23:55:43.821 - error:     POST /api/v1/users
            from: 127.0.0.1, mime: multipart/form-data
            result: failed - Username `ala` is already taken.
Error: Username `ala` is already taken.
   at new SealiousErrors.Error (/home/arkadiusz/Projects/Sealious-development/Sealious/lib/response/error.js:6:12)
   at new SealiousErrors.ValueExists (/home/arkadiusz/Projects/Sealious-development/Sealious/lib/response/error.js:30:12)
   at /home/arkadiusz/Projects/Sealious-development/Sealious/lib/core-services/user_manager.js:18:12
   at bound (domain.js:250:14)
   at runBound (domain.js:263:12)
   at tryCatcher (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/util.js:26:23)
   at Promise._settlePromiseFromHandler (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/promise.js:503:31)
   at Promise._settlePromiseAt (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/promise.js:577:18)
   at Promise._settlePromises (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/promise.js:693:14)
   at Async._drainQueue (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/async.js:123:16)
   at Async._drainQueues (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/async.js:133:10)
   at Immediate.Async.drainQueues [as _onImmediate] (/home/arkadiusz/Projects/Sealious-development/Sealious/node_modules/bluebird/js/main/async.js:15:14)
   at processImmediate [as _immediateCallback] (timers.js:371:17)
adwydman commented 8 years ago

Just a heads up - Sealious.Dispatcher.resources and Sealious.Dispatcher.datastore won't work in Sealious 0.7, instead we'll use Sealious.ResourceManager and Sealious.Datastore.

kuba-orlik commented 8 years ago

Please add unit tests to make sure that this bug does not pop up again

adwydman commented 8 years ago

Remember that his is a merge to latest, not to next.