search

sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

Make the Plugin Manager output easier to read #260

Closed kuba-orlik closed 8 years ago

kuba-orlik commented 8 years ago

I've used the resolve package to make the PluginManager behave correctly when used on an app with npm link-ed Sealious plugins.

Now the PluginManager's output is separated into info and debug messages, to make them more readable.

PluginManager's output before this commit:

11:34:53.973 - info: Checking /home/arkadiusz/Projects/Placetag/package.json for Sealious plugins...
11:34:53.994 - info:    ✓ found plugin sealious-channel-rest
11:34:54.710 - info: Checking /home/arkadiusz/Projects/Placetag/node_modules/sealious-channel-rest/package.json for Sealious plugins...
11:34:54.711 - info:   No plugins found.
11:34:54.712 - info:    ✓ found plugin sealious-datastore-mongo
{ [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
js-bson: Failed to load c++ bson extension, using pure JS version
11:34:54.863 - info: Checking /home/arkadiusz/Projects/Placetag/node_modules/sealious-datastore-mongo/package.json for Sealious plugins...
11:34:54.864 - info:   No plugins found.
11:34:54.865 - info:    ✓ found plugin sealious-www-server
11:34:54.865 - info: Checking /home/arkadiusz/Projects/Placetag/node_modules/sealious-www-server/package.json for Sealious plugins...
11:34:54.867 - info:   No plugins found.
11:34:54.868 - info: Checking /home/arkadiusz/Projects/Placetag/node_modules/sealious/package.json for Sealious plugins...
11:34:54.872 - info:    ✓ found plugin sealious-datastore-tingo
11:34:54.983 - info: Checking /home/arkadiusz/Projects/Placetag/node_modules/sealious/node_modules/sealious-datastore-tingo/package.json for Sealious plugins...

After, Logger set up to debug level:

19:18:07.436 - info: Loading plugins...
19:18:07.460 - debug: sealious (/home/kuba/projects/Sealious/sealious/package.json) requires: sealious-datastore-tingo
19:18:07.543 - info:    ✓ sealious-datastore-tingo
19:18:07.615 - debug: placetag-app (/home/kuba/temp/Placetag/package.json) requires: sealious-channel-rest, sealious-datastore-mongo, sealious-www-server
19:18:07.616 - debug: sealious-channel-rest (/home/kuba/temp/Placetag/node_modules/sealious-channel-rest/package.json) requires: sealious-www-server
19:18:08.236 - info:    ✓ sealious-www-server
19:18:08.238 - info:    ✓ sealious-channel-rest
{ [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
js-bson: Failed to load c++ bson extension, using pure JS version
19:18:08.353 - info:    ✓ sealious-datastore-mongo
19:18:08.357 - info:    ✓ sealious-www-server

And after with info debug level:

19:18:07.436 - info: Loading plugins...
19:18:07.543 - info:    ✓ sealious-datastore-tingo
19:18:08.236 - info:    ✓ sealious-www-server
19:18:08.238 - info:    ✓ sealious-channel-rest
{ [Error: Cannot find module '../build/Release/bson'] code: 'MODULE_NOT_FOUND' }
js-bson: Failed to load c++ bson extension, using pure JS version
19:18:08.353 - info:    ✓ sealious-datastore-mongo
19:18:08.357 - info:    ✓ sealious-www-server
arkadiusz-wieczorek commented 8 years ago

@kuba-orlik your changes doesn't work. We don't have information about plugin name. I've checked 'origin/issue#259_correct_plugin_manager_output' branch. (sealious 0.6.23)

23:52:45.539 - info: Loading plugins...
23:52:45.558 - debug: sealious (/home/arkadiusz/Projects/Sealious/sealious/package.json) requires: sealious-datastore-tingo
23:52:45.638 - info:    ✓ ${plugin_name}
23:52:45.640 - debug: hello-world (/home/arkadiusz/Projects/Sealious/hello-world/package.json) requires: sealious-channel-rest
23:52:45.641 - debug: sealious-channel-rest (/home/arkadiusz/Projects/Sealious/hello-world/node_modules/sealious-channel-rest/package.json) requires: sealious-www-server
23:52:46.078 - info:    ✓ ${plugin_name}
23:52:46.081 - info:    ✓ ${plugin_name}