search

sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

Improve field type text #269

Closed arkadiusz-wieczorek closed 8 years ago

arkadiusz-wieczorek commented 8 years ago

@kuba-orlik I propose add second field-type-just-text or field-type-simple-text which would be returns simple text as previous field-type-text. Because at now we have problem e.g. with user manager for which the tests don't pass.

var Sealious = require("sealious");
var user = new Sealious.ChipTypes.ResourceType({
    name: "user",
    fields: [{
        name: "username",
        type: "text", ←
        required: true
...
});
kuba-orlik commented 8 years ago

I suggest we solve that with the .valueOf trick :)

arkadiusz-wieczorek commented 8 years ago

yep. :)

Best regards | Pozdrawiam,Arkadiusz Wieczorek JavaScript developer co-founder of Placetag.pl github.com/arkadiusz-wieczorek

On 17 February 2016 at 15:37, Kuba Orlik notifications@github.com wrote:

I suggest we solve that with the .valueOftrick :)

— Reply to this email directly or view it on GitHub https://github.com/Sealious/sealious/pull/269#issuecomment-185231541.

adwydman commented 8 years ago

What is up with this pull request?

kuba-orlik commented 8 years ago

From our trello board I infer that this was tested, works and only waits for acceptance and a merge.

I think that the mission here was to sanitize the text by default.

@adwydman if you have some time on your hands please look through this PR. I don't think it's a good idea to merge it to v0.6, and lose it in v0.7. So maybe it should be moved to v0.7?

adwydman commented 8 years ago

@kuba-orlik I think it should be merged to references.

adwydman commented 8 years ago

Would you like me to do it now?

kuba-orlik commented 8 years ago

If you consider this branch to be functional and well-tested, please do merge it to references

adwydman commented 8 years ago

This branch was merged to references.

kuba-orlik commented 8 years ago

@adwydman would you consider updating the User Reference to reflect the change from this PR?

adwydman commented 8 years ago

But I don't see anything that should be update there.

kuba-orlik commented 8 years ago

Field-type-text's storage format surely needs updating

adwydman commented 8 years ago

I didn't implement the changes, so I don't really know what to update.