change fromError to to_object and adjust tests

sealcode / sealious

An extensible, declarative node framework

25 stars 2 forks source link

change fromError to to_object and adjust tests #274

Closed adwydman closed 8 years ago

adwydman commented 8 years ago

What a collosal change - I know. Nevertheless Sealious.Error has method to_object and I believe to_object better describes as method than fromError. :)

kuba-orlik commented 8 years ago

How does that better describe the function? Respones are always object. What makes this function unique is that it creates a response from an Error

adwydman commented 8 years ago

Oh, I'm sorry. I guess I was too hasty and didn't really understand what that method does.

But maybe this signals something anyway?

kuba-orlik commented 8 years ago

Yes, I think that definitely Response and Errors are in for a rewrite :)

adwydman commented 8 years ago

Well then at least this PR gave us some conclusions. :) closed