sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

`is_proper_declaration` is not a function #279

Closed adwydman closed 8 years ago

adwydman commented 8 years ago

There's a test in field-type.test.js:

it("should use default .is_proper_declaration", function(done){
                var return_value = test_field_type.is_proper_declaration({});
                if (typeof return_value != "boolean" || return_value != true) {
                    done(but_it_didnt);
                } else {
                    done();
                }
            });

is_proper_declaration method definition is nowhere to be found in the project.

kuba-orlik commented 8 years ago

It was used for field_type_reference to check whether declared in params allowed resource_types exist

adwydman commented 8 years ago

Should it be still existing?

kuba-orlik commented 8 years ago

Well, currently it has been cleared out during one of the refactors. I think that it should definitely be existing, and single_reference should be using it.