search

sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

Change the decode default method to return a resolved Promise #285

Closed adwydman closed 8 years ago

adwydman commented 8 years ago

As @kuba-orlik and I spoke on the latest meeting, decode should return a resolved Promise.

kuba-orlik commented 8 years ago

Is this PR about just changing the behavior of the default decode method, or about changing the decode method API so all field-types' decode methos have to return Promises?

adwydman commented 8 years ago

This PR is a result of this discussion

adwydman commented 8 years ago

@kuba-orlik Can we decided what to do with this PR?

adwydman commented 8 years ago

I'm closing this PR, as we decided that the default methods should return synchronously.