search

sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

Get rid of the 'accept, reject' interface #290

Closed kuba-orlik closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 41.035% when pulling 2619684b2e5e0e77278130b67ae9fad23815578f on no_accept_reject_interface into 95a02b3bf4fd419a097288a74443952c5496ef9d on alpha.

kuba-orlik commented 8 years ago

I'll correct the coverage soon :)

kuba-orlik commented 8 years ago

@adwydman Coveralls seems to be undergoing some server issues, but as you can manually check I've raised the coverage to 46%. Please review and merge this branch :)

adwydman commented 8 years ago

I love how you created a separate function to test is_proper_value <3 I assume that the change is backwards compatible and doesn't right anything, right?

kuba-orlik commented 8 years ago

Yep, the test_is_proper_value method just calls describe and it as usual, no breaking changes here :)

kuba-orlik commented 8 years ago

When you decide to merge it, please remember to merge this thing as well: https://github.com/sealcode/sealious-user-reference/pull/1 :)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.1%) to 46.444% when pulling 1791b041890f6b7396d8e212beff124de8e5da04 on no_accept_reject_interface into f3e7d0c3d728f8441d784e8f9663efa03ea3bb6c on alpha.

adwydman commented 8 years ago

Merged here and there. :)