search

sealcode / sealious

An extensible, declarative node framework
25 stars 2 forks source link

Change 'ResouceType' to 'Collection' #291

Closed kuba-orlik closed 8 years ago

kuba-orlik commented 8 years ago

This is a breaking API change. Now you create what was previously known as a ResourceType like so:

new Sealious.Collection({...declaration

Please note that this change required updating the https://github.com/sealcode/sealious-integration-tests. I've pushed the necessary changes to the integration tests into the alpha branch of it's repo.

adwydman commented 8 years ago

I think there were no tests for ResourceType, are you sure that this change doesn't break anything?

kuba-orlik commented 8 years ago

Integration tests pass! That means that the relations between the channels and collections are kept intact :)

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 44.343% when pulling 0a3a3d7202e3edd862e657a8ac975402325cc3a8 on change_resouceType_to_collection into f3e7d0c3d728f8441d784e8f9663efa03ea3bb6c on alpha.

adwydman commented 8 years ago

All right, merging.

adwydman commented 8 years ago

@kuba-orlik Remember to adjust the documentation and user guide. :)

kuba-orlik commented 8 years ago

https://github.com/sealcode/sealious-user-reference/pull/2 I've updated the user-reference :)

kuba-orlik commented 8 years ago

(please, review it)