Closed adwydman closed 8 years ago
Hmmm that doesn't seem right - I think that we should use Boom
only for user-facing errors. We can just throw new Error("message")
in all the other places - they will show up in the logger, but in user-facing output :)
I see. Well, previously this message was in ValidationError
, not a regular Error. I think this branch can help us specify which errors are for the developers and which are for users. :)
Surely. Do you need some more assistance right now?
No, I want to do it myself.
@kuba-orlik Please check the changes know, I've made them in collection.js
and chip-manager.js
.
Adrian rightfully noted that using Boom would favor REST and make Sealious less channel-agnostic. We've agreed not to do that.
This branch is still under construction.
@kuba-orlik I just want to make sure that this is what you want.
In
chip-manager.js
I replacedthrow new Errors.ValidationError
withthrow new Boom.notFound
. This is what this error prints: