search

seald / nedb

The JavaScript Database, for Node.js, nw.js, electron and the browser
MIT License
351 stars 32 forks source link

Github Actions CI publish always tags as beta #13

Closed arantes555 closed 2 years ago

arantes555 commented 2 years ago

${{ github.event.release.tag_name }} does not seem to work

FossPrime commented 2 years ago

Along the same lines... The versioning scheme in use breaks some semantic versioning parsers... To the point where I can't even select 2.1.0 stable from a dependency UI.

How TypeScript does it:

  1. 4.4.0-beta
  2. 4.4.0-dev.n
  3. 4.4.1-rc
  4. 4.4.2 (Stable-ish)

How we did it:

  1. 2.1.0-beta
  2. 2.1.0-69
  3. 2.1.0 ????

Screenshot from 2021-10-25 17-04-34 Screenshot from 2021-10-25 17-06-50

arantes555 commented 2 years ago

I do not understand how this would breaks semver in any way. I don't think it does. If there's an issue here, I believe it would be with your UI 🤷 Sorry

FossPrime commented 2 years ago

I don't think it's a coincidence that TypeScript never mixes stable versions with pre-release versions.

One fix is publishing the stable version to 2.1.1, and subsequent patches/beta versions to 2.1.2-foobar, like TS. But it does appear that the current scheme does not in anyway violate semver 2.0.