Closed oskCom closed 2 years ago
Indeed, I don't know why we didn't see this before, I guess I'll need to double down the typings tests.
In any case, your PR cannot be merged into master if you want a 2.x.x, and is not correct because the first parameter can also be nullish.
Here is my suggested change: https://github.com/seald/nedb/tree/2.x.x I released it as a prepatch 2.2.2-0, could you confirm it works?
I released the stable 2.2.2 that addresses the issue, the 3.0.0 will have the fix as well when published.
Here is my suggested change: https://github.com/seald/nedb/tree/2.x.x I released it as a prepatch 2.2.2-0, could you confirm it works?
Good suggestion. Sure, this code is better. I was able to confirm that it works
I released the stable 2.2.2 that addresses the issue, the 3.0.0 will have the fix as well when published.
Thank you for the new version release.
I'm trying to use nedb from typescript. But I get an error.
nedb version v2.2.1
sample code
Symptoms typescript error occurs
Error details Expected 0 arguments, but got 1.ts(2554)