gzip compression - Githubissues

sealedtx / java-youtube-downloader

Simple, almost zero-dependency java parser for retrieving youtube video metadata

Other

413 stars 115 forks source link

gzip compression #101

Closed Grodou closed 2 years ago

Grodou commented 2 years ago

Accept gzip compression for text responses (html/json):

reduce network usage
speed up transfers

Enabled by default, it can be changed:

Config.setCompressionEnabled(false)
Config.Buider.enableCompression(false)

Since execution time is mostly spent on server process and network, speed tests are not reliable.

sealedtx commented 2 years ago

@Grodou thank you very much for you contribution! Do you have plans for some other features implementation? So I can include them into one release later?

Grodou commented 2 years ago

@sealedtx You're welcome. I have no plan for new features right now, but I'd like to:

fix some little mistakes : download retries (does not retry even if maxRetries == 1), video formats (videoFormats should return video formats only (without audio), bestVideoFormat as well, or maybe I don't understand something)
make some cleanings (Subtitles class is useless)
improve code style: remove warnings (unused imports, resource leak), empty lines
correct tests

sealedtx commented 2 years ago

@Grodou ok, so I will merge this one and wait for your fixes before making a new release.

videoFormats should return video formats only (without audio)

As VideoWithAudioFormat extends VideoFormat I decided to return video with audio format in videoFormats because it is basically video format too For others bug fixes and improvements I have no objections, will be happy to see them, thank you

Grodou commented 2 years ago

@sealedtx Alright, should I make a single or multiple PRs ? (the download retries fix could fit in a single character)

sealedtx commented 2 years ago

@Grodou single PR for bug fixing and improvements