search

sealedtx / java-youtube-downloader

Simple, almost zero-dependency java parser for retrieving youtube video metadata
Other
413 stars 115 forks source link

fix bug with extracting transform and initial functions #39

Closed kangsLee closed 4 years ago

kangsLee commented 4 years ago

There is a problem related to the regex, please check it.

sealedtx commented 4 years ago

@kangsLee Hi! Thank you for contribution. Could you please provide some information about problem and where did you find solution (debugging youself or some similar projects like youtube-dl, etc.) just to keep log.

kangsLee commented 4 years ago

@sealedtx I'm sorry for not describing it in detail.

Issue When I found this project yesterday, it worked very well, but it doesn't work now. The current pattern causes the following error. YoutubeException$CipherException: Could not parse js function

solution

  1. initial functions (CachedCipherFactory.class::INITIAL_FUNCTION_PATTERNS) regex youtube-dl/commit/e450f6cb634f17fd4ef59291eafb68b05c141e43

  2. CachedCipherFactory::getTransformFunctions regex by myself

Thank you for making a good project. 😄