sealedtx / java-youtube-downloader

Simple, almost zero-dependency java parser for retrieving youtube video metadata
Other
413 stars 115 forks source link

Search feature #99

Closed Grodou closed 2 years ago

Grodou commented 2 years ago

Implements #92 Search feature Search using filters and sort order. Parse videos (including movies), playlists, channels and shelves.

sealedtx commented 2 years ago

@Grodou amazing work! I left some comments, mostly about namings and redundant code, please take a look Thank you very much for contribution

Grodou commented 2 years ago

@sealedtx Thank you! It was no piece of cake :) I'll make some changes and provide a better version soon.

Grodou commented 2 years ago

There are 3 new kinds of item renderers, they are all:

They're not really suitable as items, they are QueryElements. Not the best name ever.

As results may change from a moment to few seconds later, advanced tests are tricky. Especially for refinements, sometimes there are, sometimes not. The related test worked for some times, but is not reliable, it is commented for now.

sealedtx commented 2 years ago

@Grodou I believe lot of research was done to implement this feature, great job! Thank you! Please, ping me, when you finish and PR will be ready to merge

Grodou commented 2 years ago

Just a last new feature: force exact query to avoid auto-correction. In ParserImpl.parseSearchResultElement, there's still a console print for unknown element types. @sealedtx Ready to merge for me, I won't investigate any further for now. I'm glad I could help. Cheers

sealedtx commented 2 years ago

@Grodou great job, really appreciate your interest and your contribution!

Grodou commented 2 years ago

@sealedtx You're very welcome.