sealerio / cluster-spec

cluster definition of specification in center of distributed application
Apache License 2.0
1 stars 1 forks source link

suggestions for the cluster-spec repository #2

Open bxy4543 opened 2 years ago

bxy4543 commented 2 years ago

suggestions for the cluster-spec repository

  1. The warehouse name is cluster-spec, but the warehouse contains not only the cluster spec structure, but also structures such as plugin, config, and cluster status.
  2. I found that the cluster spec structure is too simple, we need to optimize it to meet more scenarios.
  3. The cluster status structure should record the status of the cluster deployed by sealer, but I found that the status structure is empty, we should record all relevant status in the cluster status, such as config, plugin, and the base image of the cluster , application mirroring, etc.
  4. Our api version is not standardized, I found that there are v1, v1beta1, v2, in fact a correct version should be v_alpine-=>v_beta-=>v_
  5. Use the correct GroupVersion: The group is cluster.sealer.cool in the [definition](https://github.com/sealerio/cluster-spec/blob/d9211fb6deeda4c930a60df06b7da4a280f70bd8/v2/groupversion_info.go#L29) but sealer.cloud is used in the Clusterfile.
root@iZj6c5z9rk0weftpz32jeoZ:~# cat /root/.sealer/my-cluster/Clusterfile
apiVersion: sealer.cloud/v2
kind: Cluster
allencloud commented 2 years ago

@bxy4543 Good proposal. For your first point, my opinion is that:

For your second point, I have discussed that with @VinceCui . My opinion is that:

After the definition, we have layered architecture of ClusterImage, and the scalability of ClusterImage could be improved and it could meet more scenarios, such as Heterogeneous k8s installation.

Third point, we could add more info into status.

Good catch of your fourth point of versioning and fifth point.

@sealerio/sealer-maintainers