sealerio / sealer

Build, Share and Run Both Your Kubernetes Cluster and Distributed Applications (Project under CNCF)
http://sealer.cool
Apache License 2.0
2.06k stars 362 forks source link

fix multi-document yaml reading errors #2322

Closed maxwell-can-not-fly closed 5 months ago

maxwell-can-not-fly commented 10 months ago

Describe what this PR does / why we need it

this fixes a multi-document yaml reading issue, which may break application install

Does this pull request fix one issue?

Fixes #2299

Describe how you did it

use yaml decoder for multi-document yaml reading

Describe how to verify it

this can be reproduced by unit tests, a unit test file is added for verification

Special notes for reviews

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f07e804) 20.50% compared to head (8d45ca5) 13.43%. Report is 4 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2322 +/- ## ========================================== - Coverage 20.50% 13.43% -7.08% ========================================== Files 96 260 +164 Lines 9129 22656 +13527 ========================================== + Hits 1872 3043 +1171 - Misses 7002 19202 +12200 - Partials 255 411 +156 ``` | [Flag](https://app.codecov.io/gh/sealerio/sealer/pull/2322/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sealerio) | Coverage Δ | | |---|---|---| | [e2e-tests](https://app.codecov.io/gh/sealerio/sealer/pull/2322/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sealerio) | `8.48% <ø> (?)` | | | [unit-tests](https://app.codecov.io/gh/sealerio/sealer/pull/2322/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sealerio) | `20.75% <100.00%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sealerio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.