search

sealuzh / cloud-stove

The Cloud Stove Backend
https://api.thestove.io
Apache License 2.0
4 stars 0 forks source link

Attempt to fix the ingredient ordering issue #174 #175

Closed joe4dev closed 7 years ago

joe4dev commented 7 years ago

The cause of this ordering issues seems to be the different ways all_leafs are accessed. Sometimes, they are sorted by id (ingredient_resource_mapping, remap_more_attributes) and sometimes they are not sorted by id (generate_ingredients_data).

Currently, this issue occurs only in combination with the production data because the ordering of the ingredient ids in production is different.

joe4dev commented 7 years ago

Fixes #174

Wrong ordering before update: before

Correct ordering after update: after

inz commented 7 years ago

:+1: awesome, thanks!

On Fri, Nov 18, 2016 at 10:18 PM Joel Scheuner notifications@github.com wrote:

Fixes #174 https://github.com/inz/cloud-stove/issues/174

Wrong ordering before update: [image: before] https://cloud.githubusercontent.com/assets/8161292/20447010/cc1cdf9c-addc-11e6-9cb7-438cf0a81c4f.png

Correct ordering after update: [image: after] https://cloud.githubusercontent.com/assets/8161292/20447014/d0d3476a-addc-11e6-8d82-5f29bcb6ea7f.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/inz/cloud-stove/pull/175#issuecomment-261644314, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAXnWzuPOYoirjtEQ-ibWmb-sm08Rn4ks5q_hYXgaJpZM4K2ycy .