sealuzh / cloud-stove

The Cloud Stove Backend
https://api.thestove.io
Apache License 2.0
4 stars 0 forks source link

User range recommendations; Fixes #177 #178

Closed joe4dev closed 7 years ago

joe4dev commented 7 years ago

Add user range support as described in #177 Maintains the existing behavior when triggering single recommendations.

Range generation now separates constructing (i.e., generating the MiniZinc model) from evaluation. See 17a99c0 for more detail.

Dependency: Already rebased on PR #176

dschoeni commented 7 years ago

I started implementing the corresponding frontend parts.

GET: /recommendations_completed always returns false though, even if there are no recommendations scheduled anymore. Triggering ranges of recommendations works well however ;)

joe4dev commented 7 years ago

Works for me with the latest version and also with some legacy db dumps I migrated for testing purpose. Also works for @dschoeni now (at least after db reset)

Should be ok but might need some more testing with concurrent executions (as stated in the PR tasks)

joe4dev commented 7 years ago

Looks ready to merge for me now