seamapi / docs

Welcome to the Seam Docs.
https://docs.seam.co
4 stars 10 forks source link

Links on generated reference pages link to GitHub instead of GitBook #292

Closed razor-x closed 2 weeks ago

razor-x commented 1 month ago

See https://app.gitbook.com/o/jhFodLh6YFJJYK6Lv9wE/s/ADj4uhM7zWsbPKzLTjhZ/~/revisions/i8iKVOhcZBt6hcSnYnuZ/api-clients/access-control-systems/systems/list

mikewuu commented 1 month ago

I ran npm run build but get an empty generated file in generated-docs/sdk/javascript/acs/systems/list.md

CleanShot 2024-08-13 at 01 10 59@2x

Am I missing a step?

razor-x commented 1 month ago

@mikewuu SDK pages are not templated yet. We're only working on /api first.

razor-x commented 1 month ago

Also, we are working off the beta branch: https://github.com/seamapi/docs/blob/beta/docs/api/acs/systems/list.md

mikewuu commented 4 weeks ago

@razor-x aren't the links suppoesd to be relative (so they link to github)? Here's a file on main that isn't generated that shows they link to github too

https://github.com/seamapi/docs/blob/beta/docs/capability-guides/access-systems/assigning-credentials-to-users.md

razor-x commented 4 weeks ago

@mikewuu They are supposed to link to gitbook when looking on the gitbook hosted version.

razor-x commented 4 weeks ago

Lets revisit this one after we do these two, it might fix the issue 🤷