seamapi / docs

Welcome to the Seam Docs.
https://docs.seam.co
4 stars 10 forks source link

Fix more old api ref paths #317

Closed mikewuu closed 2 weeks ago

mikewuu commented 3 weeks ago

extension of #313

This PR updates the missed paths mentioned in https://github.com/seamapi/docs/pull/313#issuecomment-2305459938

razor-x commented 3 weeks ago

I can't tell what was changed in the diff: it's all one line. I still see links like this though: <a href="access-control-systems/users/suspend-a-user.md"> and this doesn't seem to fix the page urls like https://docs.seam.co/latest/~/revisions/c4FVh9dgZ4L6PRgYYhk8/api/workspaces/reset-workspace

If updating this table manually is too much right now, we can just generate it instead once we close https://github.com/seamapi/docs/issues/305

mikewuu commented 3 weeks ago

I can't tell what was changed in the diff: it's all one line.

Unfortunately not sure what we can do about the diff. I will manually click each link once completed.

I still see links like this though: <a href="access-control-systems/users/suspend-a-user.md"

@razor-x sorry, meant to mark this as a draft, there are still a lot more urls to rename. Hadn't gotten to users/suspend yet.

this doesn't seem to fix the page urls like https://docs.seam.co/latest/~/revisions/c4FVh9dgZ4L6PRgYYhk8/api/workspaces/reset-workspace

I'm not sure that preview is showing the current PR:

  1. Doing a search for /reset-workspace doesn't returning anything except the redirect (as expected)

CleanShot 2024-08-26 at 21 07 51@2x

  1. Manually changing it to reset_sandbox (the new path), returns a page not found.

CleanShot 2024-08-26 at 21 04 23@2x

  1. That page has content, but is empty in the preview gitbook
razor-x commented 3 weeks ago

Ok, I am going to debug some of the link issues. I'll reach out to GitBook support if I can't figure out whats broken. In the meantime as long as every link in the docs either points to the new page, or one that has a redirect, we should be ok. I think it's ok to leave the old (redirected) urls in OVERVIEW.md since we will be able to generate this entire file with the codegen. I'm mostly concerned with updating the links outside of api-clients.