seamapi / edgespec

☃️ an API framework for everywhere.
MIT License
5 stars 2 forks source link

feat: Add CommonJS module to build output #159

Closed louis-pre closed 4 days ago

louis-pre commented 1 month ago

Context

Working on SPF (standard provider fakes), we need to import edgespec in seam-connect which is a CommonJS project. Unfortunately, edgespec's build is currently ES only which means it can not be imported synchronously from a CJS project. Importing it asynchronously is not a good option here as it causes other issues down the line.

This partially reverts https://github.com/seamapi/edgespec/pull/138

Changes

! Risk

The original PR by Max was to resolve some kind of type issue but I could not reproduce it myself

louis-pre commented 1 week ago

Moved back to draft as I am still having issues