search

seamapi / react

Seam Components are a set of white-labeled UI elements that can be added to your application in seconds. Use them in any app as native web components or as React components and hooks.
https://react.seam.co
MIT License
7 stars 2 forks source link

feat: Add disableDeviceManufacturerInformation prop #627

Closed razor-x closed 6 months ago

razor-x commented 7 months ago
dawnho commented 7 months ago

Could you add screenshots that illustrate what the prop changes?

dawnho commented 7 months ago

I don't think we need to get so granular with these flags. i wanted the whole device info / details section to get hidden, instead of these granular row by row flags.

I'm a bit miffed that this got merged after I left a similar comment in the PR: https://github.com/seamapi/react/pull/623

razor-x commented 7 months ago

Could you add screenshots that illustrate what the prop changes?

@dawnho The storybook for this branch will let you see all the different component states: https://react-hsmbsz7gy.seam.vc/?path=/docs/components-devicedetails--docs

razor-x commented 6 months ago

After discussion, this prop is still ambiguous. Closing in favor of https://github.com/seamapi/react/pull/629