seamless-protocol / seamless-interface

https://seamless-interface.vercel.app
Other
7 stars 4 forks source link

My Holdings, Specific Strategy Breakdown of Balance, Returns and Rewards [My Dashboard] #437

Open rcqiao opened 4 months ago

rcqiao commented 4 months ago

Name of feature/metric: My Holdings --> For Each Specific ILM Strategy, a Breakdown of Balance, Returns and Rewards

Description of feature/metric: For each ILM strategy that the user has an active position in, the following data points: (a) the active balance (in both underlying token amount AND $USD value amount); (b) the total return so far for that particular strategy on that active position (in $USD); (c) The total rewards generated on that specific position in $USD (and broken down by the reward tokens, # of tokens for each)

Questions/considerations:

Shown on the my dashboard page

Picture from design (if available): Note this image shows rewards only in SEAM, in the future there will likely be multiple rewards tokens. Image

Estimated Timeline:

Requirements/Data Sources: First column is zero effort. Current rewards is also zero effort. Regarding middle column we can get it from Dune or from Subgraph. If we are getting it from Dune query would not be super complex but will be user specific so it could take credits for each user separately. On subgraph I think we would have no problem with that.

kitanovicd commented 4 months ago

Regarding rewards generated column: Does this show only current claimable rewards or it should show all time rewards for specific strategy?

rcqiao commented 4 months ago

currently whats claimable

rcqiao commented 4 months ago

For a specific vault strategy, the total earnings examples can be found on:

definitive https://app.definitive.fi/community/dd7b4c83-b26c-49bb-8d78-63d52ff9dc5f?tab=summary Image

It looks like Beefy also has something similar after you deposit into a strategy, that specific strategy shows a deposit amount, balance now, yield and pnl https://app.beefy.com/vault/compound-base-usdc Image

Image

Image

kitanovicd commented 3 months ago

This should be combination of other tickets. No effort for this ticket specifically.

rcqiao commented 3 months ago

interdepency / assumption we have a subgraph because of the total earned yield/profit/loss tickets

kitanovicd commented 3 months ago

Regarding total earned column it will depend on this ticket: https://github.com/orgs/seamless-protocol/projects/1/views/13?pane=issue&itemId=71019766 This means that this ticket is not dependant on Subgraph or Dune.