seamless-protocol / seamless-interface

https://seamless-interface.vercel.app
Other
7 stars 4 forks source link

feat: fetch strategy detail #499

Closed kitanovicd closed 2 weeks ago

kitanovicd commented 1 month ago

Implemented data fetching for strategy details component described in #491 . Data is fetched in function and hooks are build on top of functions. This is done so it is easier to user them in case of loop or something similar. PR should be very straight forward and I would love to pay special attention to caching.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seamless-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 4:17pm
WingsDevelopment commented 4 weeks ago

Now when I think of this 'fetch' functions or any data point isolated I can almost always assume that its going to have 4 parts in order to be completed.

So i am starting to think that we might have better option for folder structure of these things, to me i would love to see for example folder: StrategyTargetMultiple (folder containing 4 files:)

I guess in same cases like in this one (StrategyTargetMultiple) we might be good to put everything in 1 file, but this should be one of the simpler ones ? For anything more complex files will grow and we also don't have as clear separation..

I am aware of that this is not small change in folder structure and also can be more time consuming to create 4x more files, but i think there are tools that can help us in doing this, we could configure in vs code command like in angular to always generate 4 files for fetch function..

Anyway this is my suggestion, let me know what you guys think?