search

seamless-protocol / seamless-interface

https://seamless-interface.vercel.app
Other
7 stars 4 forks source link

Integrate data into ILM table #509

Closed kitanovicd closed 2 weeks ago

kitanovicd commented 3 weeks ago

UI for this table is mostly done and now only data integration should be done.

Image

kitanovicd commented 3 weeks ago

I started working on this issue today. I made decent progress. I made our new config that is much more simple than then one we are currently using. Also I integrated APY data into APY column. In that column indicator was always indicating growth (arrow up) so I added indicator for negative APY also (arrow down, red colour). Also I changed first column and now we are getting strategy name, logo, description and tag from config. Integrated TVL column also. Integrated reward APR percentage hook that we already have. Also I changed some minor UI things in order for UI to match Figma. For tomorrow I will have to do UI for incentive column and to do fetching for available supply cap column and integration of it. I think tomorrow I will open PR and put it on review.

kitanovicd commented 3 weeks ago

I finished my work today for this feature. I changed UI a little bit since it was not like it is designed. Some colours were not correct and incentives button was just a number not button like on provided picture. Also I applied some minor alignment of components (columns). All of this is minor work on UI that is done on this PR as peripheral thing. Regarding data fetching I created hook for fetching TVL (Equity) and available asset cap. Also I created new config file for getting logo, name, description and type of strategy so we don't rely on old config that has a lot of unnecessary things. Also I integrated ILMRegistry contract into our FE. Now we are getting strategies dynamically from that contract and just description, name, logo and type from config. I think we should rely on config as less as possible. Moving from config to ILMRegistry will gives us a lot of flexibility in future. For example, we could configure logo, description and name of a strategy and deploy FE. UI will stay the same (strategy will not appear) until it is registered in registry contract. This means that we can finish eng tasks much earlier then marketing team so we are not late and they don't depends on us that much.

Regarding incentives column I copied button that we already have but I removed tooltip since we don't have design for tooltip. Also I left colour to be green (border) and not purple because purple looks terrible with black SEAM logo.