search

seamless-protocol / seamless-interface

https://seamless-interface.vercel.app
Other
7 stars 4 forks source link

Integrate data on portfolio summary component on dashboard page #512

Closed kitanovicd closed 2 weeks ago

kitanovicd commented 3 weeks ago

Image

Data integration for this component needs to be done since UI is merged already.

kitanovicd commented 3 weeks ago

I started working on this issue today. Integrating this data will be straight forward and I will create PR for this on Monday. Data integration will consist of integration of hook for unrealized gains (total) and of integration of hook for claimable rewards. I noticed that I need to upgrade user profit hook to return also current balance of strategy in order to display total portfolio value or I will need to code new hook for fetching strategy balance across all strategies and sum them. I am fine with both approaches and none of them represents something complex so everything will be done on Monday.

kitanovicd commented 2 weeks ago

I upgraded profit hook to return current portfolio value. I am not sure should I rename it so I opened conversation on PR about this. Also I implemented some parts of empty portfolio state. In general PR is very easy to review. I didn't code new hooks and for claimable rewards I am using already existing hook from current app.