search

sean-olson-e / Angular-and-the-ArcGIS-API-for-JavaScript

This repository contains resources to support the Esri Developer Summit presentation, Angular and the ArcGIS API for JavaScript. Here you will find all of the samples apps, presentation slides, and Readme files that provide guidance for each pattern.
27 stars 12 forks source link

sample apps should begin with latest "angular-cli-esri-map" #17

Closed jwasilgeo closed 6 years ago

jwasilgeo commented 6 years ago

Sample apps' code base should start from @andygup's https://github.com/ArcGIS/angular-cli-esri-map, correct?

Bringing this to @sean-olson-e's attention since there have been some updates by @andygup recently.

@andygup are there any pending updates remaining over at that repo?

Question for all 3 of us: do we need to support unit and functional tests for our sample apps for Dev Summit since @andygup's other repo is stripped down to the bare essentials? I have no desire to do so for my own presentation topics.

I'll begin just by going in to the sample apps I'm currently working on ("esri-loader" and "arcgis types") and run my changes through a PR.

sean-olson-e commented 6 years ago

@jwasilgeo, Having unit tests would reflect best professional practices, but I would rather not include them at this point. That may just be the pressure talking, though. I will leave it up to you two.

I am not able to access @andygup's repo since I changed my user name. I am able to access ArcGIS, just not the angular-cli-esri-map repository. The boilerplate I used for this repo did have one addition, though -- the angular-devkit/core module was need for the app to build.

sean-olson-e commented 6 years ago

Resolved