search

sean-perkins / nativescript-animated-circle

NativeScript plugin for animated progress borders on circles.
Apache License 2.0
13 stars 11 forks source link

[Feature Request] Text in the middle #4

Closed danielgek closed 7 years ago

danielgek commented 7 years ago

@sean-perkins i was about to make a pr to add this functionality to your plugin, but then i realised the ios pod don't support it.

i did a little search to find a simple pod with the current functionality an support for text(https://github.com/atecle/ATCircularProgressView)

if it's ok for you i will summit another pr with support for text

thanks!

sean-perkins commented 7 years ago

Yeah that's fine, as long as the API remains 1:1 for the end-user.

danielgek commented 7 years ago

@sean-perkins thank i will work on it then, and the other pr can wait because i actually need them both xD

danielgek commented 7 years ago

@sean-perkins btw do you absolutely need conterClock ?

sean-perkins commented 7 years ago

I don't think so, I would bet 95% of implementations only need clockwise animations.

danielgek commented 7 years ago

Cool so can i remove that feature(can't find a pod with middle text and conterclock)?

danielgek commented 7 years ago

ended up this se same pod xD but added a label as a subview on ios

sean-perkins commented 7 years ago

This now should be available with release tag 1.1.0. Great work!