Closed axelrindle closed 1 year ago
This should be mergeable now. Flags are supported and input is processed properly.
Should be additionally tested.
Also I suggest squashing on merge :smile:
Good news is, the action has passed!
Bad news, the generated file is empty. It looks as though markdown-extract ran and spat out the correct output, but then when it came time to save that output we got an empty string.
See: https://github.com/sean0x42/markdown-extract/actions/runs/4966408052
Hm that's weird. I'll look into that.
At least the action itself works now :smile:
Forgot to write to the $GITHUB_OUTPUT
variable 😅
That should do the trick.
Thinking this through, I'd like for you to merge this when you have time @axelrindle. That way the squash commit is attributed to your account rather than mine. There's no rush of course
Pull requests can only be merged by those with write access to the source repository.
That is super frustrating! I was experimenting with some options to make it so you could merge your own PR if approved, but looks like all I can do is give complete write access (hence the invitation I accidentally sent out!)
Will merge this with a Co-authored-by tag, that's the next best thing I can think of
Sounds good to me.
It actually still gave you credit! I was worried about nothing. Thanks again!
I started working on issue #14.
ToDo:
Closes #14.