sean0x42 / markdown-extract

Extract sections of a markdown file. Useful for automatically extracting changelogs
https://hub.docker.com/r/sean0x42/markdown-extract
MIT License
31 stars 7 forks source link

Github Action #15

Closed axelrindle closed 1 year ago

axelrindle commented 1 year ago

I started working on issue #14.

ToDo:

Closes #14.

axelrindle commented 1 year ago

This should be mergeable now. Flags are supported and input is processed properly.

Should be additionally tested.

Also I suggest squashing on merge :smile:

sean0x42 commented 1 year ago

Good news is, the action has passed!

image

Bad news, the generated file is empty. It looks as though markdown-extract ran and spat out the correct output, but then when it came time to save that output we got an empty string.

image

See: https://github.com/sean0x42/markdown-extract/actions/runs/4966408052

axelrindle commented 1 year ago

Hm that's weird. I'll look into that.

At least the action itself works now :smile:

axelrindle commented 1 year ago

Forgot to write to the $GITHUB_OUTPUT variable 😅

That should do the trick.

sean0x42 commented 1 year ago

Thinking this through, I'd like for you to merge this when you have time @axelrindle. That way the squash commit is attributed to your account rather than mine. There's no rush of course

axelrindle commented 1 year ago

Pull requests can only be merged by those with write access to the source repository.

sean0x42 commented 1 year ago

That is super frustrating! I was experimenting with some options to make it so you could merge your own PR if approved, but looks like all I can do is give complete write access (hence the invitation I accidentally sent out!)

Will merge this with a Co-authored-by tag, that's the next best thing I can think of

axelrindle commented 1 year ago

Sounds good to me.

sean0x42 commented 1 year ago

It actually still gave you credit! I was worried about nothing. Thanks again!