search

seanabrahams / elixir-tmdb

Elixir library for themoviedb.org (tmdb)
MIT License
12 stars 9 forks source link

v0.2 #2

Open seanabrahams opened 8 years ago

seanabrahams commented 8 years ago
agustif commented 8 years ago

[1] Nice! I don't understand macros yet but so simple and so much lines saved!!

[2] TV is a hard one to pluralize, Series might come handy for a differentiation on a -one shot- vs a chapter/episode format, not sure whats best though. The api main endpoints are all in singular so maybe we stick on singular for all (maybe being flexible in somtehing like Tmdb.Movie.Search being compatible with Tmdb.Keyword.Movies (I mean using plural only when you call an associated resource (Movies by Keyword) to another resource in singular, (Tmdb.Movie.Keywords)

Maybe we can create some kind of rule of thumb in order to make sense of which is the main resource which you can scope by using singular, and leaving plural for the other, Idk.

[3] In that case, do you want me to try a shoot at it? I actually started with a search endpoint on my initial PR but ended up discarding it in order to try and stay focused on one task (Already too many endpoints for a single PR maybe) But would like to try the effort.

I have thought to, in order to have available both Tmdb.Search.movies and Tmdb.Movie.search maybe we could youse alias/import in order to achieve that without adding too much extra code. Maybe not worth it Idk, I think it's just nice to have aliases for workflow in iex when I use tab completion to try and break stuff!

agustif commented 8 years ago

Shows instead of TV could be a good plural naming, seasons makes sense too.

I don't know if we should change People for Persons or something like that in order to make the plural more obvious y'know

Search is a hard one to make sense in plural, but maybe we should end up doing something for both search and discover endpoints of the api and name that differently, Idk, maybe sticking as close to the API endpoints naming is whats best!

seanabrahams commented 8 years ago

I think we should stick to TMDb's naming so someone can read their documentation and use this library without having to look things up.

agustif commented 7 years ago

Hi Sean! How's it going, I plan to start using this in production, do you have any plans in mind? Would you like a PR on something if I may try? Thanks for all the code!

seanabrahams commented 7 years ago

Hey Agusti, all is well! Good to hear from you again. Yes, please submit PRs.

On Mon, Jul 17, 2017 at 7:51 PM, Agusti Fernandez notifications@github.com wrote:

Hi Sean! How's it going, I plan to start using this in production, do you have any plans in mind? Would you like a PR on something if I may try? Thanks for all the code!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/seanabrahams/elixir-tmdb/issues/2#issuecomment-315943242, or mute the thread https://github.com/notifications/unsubscribe-auth/AACtboylC5v6EWBfLozjcmbtqdDYhhlMks5sPB2egaJpZM4JgRc0 .