seananderson / covidseir

Bayesian SEIR model to estimate the effects of social-distancing on COVID-19
https://seananderson.github.io/covidseir/index.html
28 stars 11 forks source link

broken link from README #13

Open bbolker opened 3 years ago

bbolker commented 3 years ago

This is a very minor point.

The link on the README about installing on Windows (https://github.com/stan-dev/rstan/wiki/Installing-RStan-from-source-on-Windows) looks broken, probably on the Stan side. I don't know whether it would be better to escalate/transfer this to the Stan folks, or to link here instead https://github.com/stan-dev/rstan/wiki/Configuring-C---Toolchain-for-Windows (or the generic RStan getting started page: https://github.com/stan-dev/rstan/wiki/RStan-Getting-Started)

I don't know whether anyone is encountering issues with RStan vs cmdstanr, but I can imagine it coming up soon. https://mc-stan.org/cmdstanr/articles/cmdstanr.html#comparison-with-rstan-1

seananderson commented 3 years ago

Thanks! I've updated to the the generic wiki page.

We looked into using cmdstanr when trying to access the Stan 2.26 ODE solver interface (lets one pass arbitrary data and parameters via ...). At the time, I thought cmdstanr didn't have a variational Bayes or MAP (rstan::optimizing()) interface yet, but I think I was wrong. The long delay in getting Stan 2.26 into rstan would make me seriously consider cmdstanr in the future—especially once on CRAN.