seanap / Audible.com-Search-by-Album

Mp3tag Web Sources Scripts
84 stars 17 forks source link

Spelling Error Fix & Fixing Cover Images #35

Closed brianbeergod closed 8 months ago

brianbeergod commented 8 months ago

Fixed a spelling error early in the code (small, but I couldn't commit code and not suggest it)

I couldn't get the covers to work at all - I ended up running the debugger and found where it removed it. I added it in so that the image now works properly.

I personally changed "comment" to "description" but that was a personal change - I didn't mean to commit that specifically

seanap commented 8 months ago

Thanks for fixing the cover images!

Regarding the "comment" to "description", there is no "description" id3 tag, that tag only exists in MP4 ("desc"). The way you have it would create a new custom tag for mp3 books and not use a standard built-in tag. https://docs.mp3tag.de/mapping/

brianbeergod commented 8 months ago

Yeah, no worries. I use it specifically for my set up. I was pretty tired when I was committing and didn't realize that it also copied that piece over.

I was trying to get the subtitle to work properly last night but couldn't. I might have another commit coming there if I can get it working.