Resolve #18 Incorrect attribute example in README

seanbehan / videojs_rails

Video JS for Rails 3.1 Asset Pipeline

91 stars 71 forks source link

Resolve #18 Incorrect attribute example in README #19

Closed ain closed 9 years ago

richardun commented 9 years ago

Yeah, this example confused me for a little while until I noticed it. I fixed it in mine also, but made it work for Live feeds as well, and made it more flexible for other video types. Check it out here: https://github.com/richardun/videojs_rails

ain commented 9 years ago

I'm still on Rails 3 on all legacy code, haven't had time to update. Does your fork have legacy support?

grzlus commented 9 years ago

@richardun I'll check your changes after work. I'll create pull request and made some changes.

ain commented 9 years ago

:+1: