search

seanbehan / videojs_rails

Video JS for Rails 3.1 Asset Pipeline
91 stars 71 forks source link

Don’t force users of gem to rely on a CDN for serving video player SWF. #24

Closed zetter closed 9 years ago

zetter commented 9 years ago

Hello,

We don’t want to depend on a CDN that may be down or be blocked in other countries. The more CDNs and services depended on the more likely that one of them may have problems.

This commit introduces the SWF back in to the gem that was removed in [1]. Users of the gem will now be able to override video js’s default behaviour in their own project by following the instructions in [2].

We could work around our need to not use the CDN version of the SWF file by including it in our project, but since the version of the SWF should be kept in sync with the version of video js I think it makes more sense for it to live in the gem.

I'd be interested to know if there was a reason why the SWF was removed from the project (since it is easy to update with the other dependencies). If others don't feel as strongly as me about having the SWF available then it might not make sense to merge this back in.

Also, it would be good to know reasons why someone may want to use a locally hosted video.js file but want to use the SWF from the CDN (instead of using a CDN for both as described in [3])

[1] https://github.com/seanbehan/videojs_rails/commit/65d7aa707984f2798d7d172d1b8b90df41bc0c98 [2] https://github.com/videojs/video.js/blob/master/docs/guides/setup.md#self-hosted [3] https://github.com/videojs/video.js/blob/stable/docs/guides/setup.md#cdn-version

nateware commented 9 years ago

This is fixed in pull request #28