seanbehan / videojs_rails

Video JS for Rails 3.1 Asset Pipeline
91 stars 71 forks source link

Type on styling? #32

Closed chrism closed 9 years ago

chrism commented 9 years ago

Hi,

I feel like this has a typo which is making some of my styling break

https://github.com/seanbehan/videojs_rails/blob/master/lib/videojs_rails/view_helpers.rb#L18

shouldn't it be

options[:class] = [options[:class], "video-js vjs-default-skin"].join(' ')

not

options[:class] = [options[:class], "vide-js vjs-default-skin"].join(' ')

(video-js not vide-js)

thanks

ryderhicks commented 9 years ago

Yes, this is causing issues for me as well.

grzlus commented 9 years ago

I'll make release today to RubyGems

chrism commented 9 years ago

Fantastic, thanks!

:+1:

grzlus commented 9 years ago

Typo was made before my whole upgrade. I don't have time to upgrade all versions today.