search

seanbehan / videojs_rails

Video JS for Rails 3.1 Asset Pipeline
91 stars 71 forks source link

Adding missing (recent) versions of video-js #8

Closed kreeger closed 10 years ago

kreeger commented 10 years ago

I noticed this library was locked in at video-js v4.1.0. For our uses, that version has a pretty nasty bug that causes problems with dispatching timeupdate events — https://github.com/videojs/video.js/issues/620 — and numerous other versions have popped up since then.

I've added each subsequent version incrementally as a new commit to this library, so that if others need to lock in a specific version of video-js, they can do so.

In my fork, I've tagged each commit with the particular version number of video-js as well. GitHub PRs don't allow for tags to be in the PR, so these won't carry over. If you don't want to go through the trouble of tagging each commit, and subsequently building and pushing those versions to rubygems.org, and you'd like those to be on rubygems.org, you could give me push access to this repo and I can take care of it. If not, certainly no biggie there (and no offense taken!); just a convenience.

Thanks for hosting this library, @seanbehan!

seanbehan commented 10 years ago

@kreeger Thanks for doing this. I've added you to the repository. Merge away!

kreeger commented 10 years ago

All set. Thanks @seanbehan!

kreeger commented 10 years ago

@seanbehan I just realized these new tags will need to be pushed to RubyGems.org as well. Would you like me to take care of that, too?

seanbehan commented 10 years ago

Sure. Feel free to publish to ruby gems. I think repo access is all you need to add yourself to the gemspec.

Cheers

Sent from my iPhone

On Apr 10, 2014, at 10:49 AM, Ben Kreeger notifications@github.com wrote:

@seanbehan I just realized these new tags will need to be pushed to RubyGems.org as well. Would you like me to take care of that, too?

— Reply to this email directly or view it on GitHub.

kreeger commented 10 years ago

@seanbehan It appears I need to be granted access to the gem on RubyGems.org.

$ rake release
videojs_rails 4.2.0 built to pkg/videojs_rails-4.2.0.gem.
Tag v4.2.0 has already been created.
rake aborted!
Pushing gem to https://rubygems.org...
You do not have permission to push to this gem.

Can you hook me up? My rubygems.org email is benjaminkreeger@gmail.com.

seanbehan commented 10 years ago

Ok, you should be added now.

On Mon, Apr 14, 2014 at 8:56 PM, Sean Behan inbox@seanbehan.com wrote:

What email are you using w/ rubygems.org? I will add you as an owner.

On Mon, Apr 14, 2014 at 4:44 PM, Ben Kreeger notifications@github.comwrote:

@seanbehan https://github.com/seanbehan It appears I need to be granted access to the gem on RubyGems.org.

$ rake release videojs_rails 4.2.0 built to pkg/videojs_rails-4.2.0.gem. Tag v4.2.0 has already been created. rake aborted! Pushing gem to https://rubygems.org... You do not have permission to push to this gem.

Reply to this email directly or view it on GitHubhttps://github.com/seanbehan/videojs_rails/pull/8#issuecomment-40415763 .

kreeger commented 10 years ago

@seanbehan Thanks! The new versions are all up there now.