search

seanbsu / ChartCare

GNU General Public License v3.0
0 stars 3 forks source link

Added check to Register OnPostAsync to prevent users from selecting non-free price plans / Updated Register view to handle null plans list #39

Closed LeeMclafferty closed 2 months ago

LeeMclafferty commented 2 months ago

implements #28

seanbsu commented 2 months ago

hey Lee I noticed this PR. just wanted to mention for future reference that the implements #[issueNumber] should be in the comment of the PR with the title being a brief description of the issue implemented. Thanks , when you're ready just request a review and I'll look over it

LeeMclafferty commented 2 months ago

@seanbsu I have updated the Title / Description.

You can review, I do not see away to explicicitly request a review other than submitting this PR. Is there another step that I am missing?

seanbsu commented 2 months ago

@LeeMclafferty can you see this section on github for the PR?

image

LeeMclafferty commented 2 months ago

@seanbsu I cannot, according to this stack overflow post, that option is only available for the repo owner, not all contributiers.

https://stackoverflow.com/questions/32262295/adding-a-reviewer-to-a-github-pull-request

seanbsu commented 2 months ago

@LeeMclafferty I see so the only way is to @ a repo collaborator. good to know. alright. I'll look this over.