search

seancarmody / ngramr

R package to query the Google Ngram Viewer
Other
48 stars 9 forks source link

problem with stringr #35

Closed danhart228 closed 2 years ago

danhart228 commented 2 years ago

When I run these commands:

library (ngramr) ng <- ngram(c("hacker", "programmer"), year_start = 1950)

I get this message:

Error in stringr::str_split(grep("drawD3Chart", json, value = TRUE), ",")[[1]] : subscript out of bounds In addition: Warning message: In ngram_fetch_data(html) : NAs introduced by coercion

seancarmody commented 2 years ago

Let me have a look - it's possible that Google has changed the format of it's website

seancarmody commented 2 years ago

Yes - the website format has changed. I'll need to update the code and release an update. I will keep you posted!

danhart228 commented 2 years ago

Thank you! I appreciate your attentiveness to the issue, and love the package!

Daniel Hart Prevention Science and Psychology Rutgers University-Camden

From: Sean Carmody @.> Sent: Thursday, September 8, 2022 8:12 AM To: seancarmody/ngramr @.> Cc: Daniel Hart @.>; Author @.> Subject: Re: [seancarmody/ngramr] problem with stringr (Issue #35)

Yes - the website format has changed. I'll need to update the code and release an update. I will keep you posted!

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fseancarmody%2Fngramr%2Fissues%2F35%23issuecomment-1240633995&data=05%7C01%7Chart%40camden.rutgers.edu%7Cd6436c8830e9401046a108da91937657%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637982359779246066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RisiwhJLhe1B2%2B71C0abLJd4y5d%2FjYKTQAMV1wmrd34%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA266SFE7ESNLZTGGVKXDYUTV5HJ4PANCNFSM6AAAAAAQHVGAM4&data=05%7C01%7Chart%40camden.rutgers.edu%7Cd6436c8830e9401046a108da91937657%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637982359779246066%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NtI%2B3lC6SFwVIEKxhzmhYZEyBcfMIVq7iAtDfgiCZkI%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

seancarmody commented 2 years ago

Thanks. Making progress - should be ready to upload a new version within a day

danhart228 commented 2 years ago

Excellent news to learn about the progress on the ngramr package. Many thanks!

Daniel Hart Prevention Science and Psychology Rutgers University-Camden

From: Sean Carmody @.> Sent: Friday, September 9, 2022 4:06 AM To: seancarmody/ngramr @.> Cc: Daniel Hart @.>; Author @.> Subject: Re: [seancarmody/ngramr] problem with stringr (Issue #35)

Thanks. Making progress - should be ready to upload a new version within a day

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fseancarmody%2Fngramr%2Fissues%2F35%23issuecomment-1241645177&data=05%7C01%7Chart%40camden.rutgers.edu%7Cce8d8b286b27420753dd08da923a43de%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637983076205943088%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sX46cnSpqaKEYLIUaVyM%2BHhEH8c3Y2xzFBy7WRJG2H8%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA266SFDQ7MVR2UUMKCTZIMLV5LV2BANCNFSM6AAAAAAQHVGAM4&data=05%7C01%7Chart%40camden.rutgers.edu%7Cce8d8b286b27420753dd08da923a43de%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637983076205943088%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZkAYVNiClzKbnExxp81CWrB%2FlIrpXT6T97Dg3l%2BtgK0%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

seancarmody commented 2 years ago

I have addressed all of the problems and the version here on GitHub should now work. I am now going through the release testing routine. I will let you know when it's up on CRAN as well.

danhart228 commented 2 years ago

Very much appreciated! Thank you!

Daniel Hart Prevention Science and Psychology Rutgers University-Camden

From: Sean Carmody @.> Sent: Saturday, September 10, 2022 2:48 AM To: seancarmody/ngramr @.> Cc: Daniel Hart @.>; Author @.> Subject: Re: [seancarmody/ngramr] problem with stringr (Issue #35)

I have addressed all of the problems and the version here on GitHub should now work. I am now going through the release testing routine. I will let you know when it's up on CRAN as well.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fseancarmody%2Fngramr%2Fissues%2F35%23issuecomment-1242649086&data=05%7C01%7Chart%40camden.rutgers.edu%7C2993a13511f24d5173a108da92f87d7c%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637983893203444191%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=dGfD0YGX38SZfUKTmwPoZC%2Fiw5vPqc9buaZL1Nu71Rw%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA266SFHXU3II5OBG4L4VIQTV5QVMLANCNFSM6AAAAAAQHVGAM4&data=05%7C01%7Chart%40camden.rutgers.edu%7C2993a13511f24d5173a108da92f87d7c%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637983893203444191%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4Hp2bRnowdTQWKciK4tuiO4nZ26CDqUPmksYInJzQFY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

seancarmody commented 2 years ago

CRAN release up, so I will close this issue. Let me know if you have any more problems.

danhart228 commented 2 years ago

Very, very much appreciated!

Daniel Hart Prevention Science and Psychology Rutgers University-Camden

From: Sean Carmody @.> Sent: Saturday, September 10, 2022 6:40 PM To: seancarmody/ngramr @.> Cc: Daniel Hart @.>; Author @.> Subject: Re: [seancarmody/ngramr] problem with stringr (Issue #35)

CRAN release up, so I will close this issue. Let me know if you have any more problems.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fseancarmody%2Fngramr%2Fissues%2F35%23issuecomment-1242814951&data=05%7C01%7Chart%40camden.rutgers.edu%7Cb863e2d733c74790cacb08da937d7527%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637984464305016458%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MVD%2FbDtNBCUyWJm7imimukhT24hN5FC27yfJA58CftU%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA266SFFVWWMWEC7FJMXZXK3V5UE5VANCNFSM6AAAAAAQHVGAM4&data=05%7C01%7Chart%40camden.rutgers.edu%7Cb863e2d733c74790cacb08da937d7527%7Cb92d2b234d35447093ff69aca6632ffe%7C1%7C0%7C637984464305016458%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JCxMNsFnJfeapgFy%2F%2F6aSMrJZgAsmwhmVUQHoZvKf8s%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>